chibenwa commented on code in PR #2442: URL: https://github.com/apache/james-project/pull/2442#discussion_r1808583430
########## mailbox/lucene/src/main/java/org/apache/james/mailbox/lucene/search/LuceneMessageSearchIndex.java: ########## @@ -1052,7 +1054,7 @@ private Query createTextQuery(SearchQuery.TextCriterion crit) throws Unsupported queryBuilder.add(createTermQuery(HEADERS_FIELD,value), BooleanClause.Occur.SHOULD); return queryBuilder.build(); default: - throw new UnsupportedSearchException(); + return new BooleanQuery.Builder().build(); // TODO: Implement Review Comment: If the underlying search engine support attachment search then the JMAP layer position it as a search criteria otherwize no? BTW maybe we should just contribute (optional) attachment indexing with Lucene? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For additional commands, e-mail: notifications-h...@james.apache.org