quantranhong1999 commented on code in PR #2464: URL: https://github.com/apache/james-project/pull/2464#discussion_r1809839039
########## server/container/guice/memory/src/main/java/org/apache/james/modules/mailbox/MemoryMailboxModule.java: ########## @@ -99,6 +97,7 @@ protected void configure() { install(new MemoryDeadLetterModule()); install(new MemoryQuotaModule()); install(new MemoryQuotaSearchModule()); + install(new LuceneSearchMailboxModule()); Review Comment: Not sure we want to use the File Directory (in `LuceneSearchMailboxModule`) for the memory app. Memory app leaving some files on the host file system after testing sounds weird, no? Likely we should use the Ram directory instead cf `LuceneMemorySearchMailboxModule`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For additional commands, e-mail: notifications-h...@james.apache.org