This is an automated email from the ASF dual-hosted git repository.

btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git


The following commit(s) were added to refs/heads/master by this push:
     new 0b818718ce JAMES-3491 Clean code JmapEventSerializer
0b818718ce is described below

commit 0b818718ce33245794c194a434b03b6c029a7ca5
Author: TungTV <vtt...@linagora.com>
AuthorDate: Thu Oct 24 22:00:01 2024 +0700

    JAMES-3491 Clean code JmapEventSerializer
---
 .../org/apache/james/jmap/change/JmapEventSerializer.scala   | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git 
a/server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/change/JmapEventSerializer.scala
 
b/server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/change/JmapEventSerializer.scala
index 3dc43c8670..76fc8b6974 100644
--- 
a/server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/change/JmapEventSerializer.scala
+++ 
b/server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/change/JmapEventSerializer.scala
@@ -79,19 +79,15 @@ case class StateChangeEventDTO(@JsonProperty("type") 
getType: String,
 }
 
 case class JmapEventSerializer @Inject()(stateChangeEventDTOFactory: 
StateChangeEventDTOFactory) extends EventSerializer {
-  private val genericSerializer: JsonGenericSerializer[StateChangeEvent, 
StateChangeEventDTO] = JsonGenericSerializer
-    .forModules(stateChangeEventDTOFactory.dtoModule)
+  private val genericSerializer: JsonGenericSerializer[Event, EventDTO] = 
JsonGenericSerializer
+    
.forModules(stateChangeEventDTOFactory.dtoModule.asInstanceOf[EventDTOModule[Event,
 EventDTO]])
     .withoutNestedType()
 
-  override def toJson(event: Event): String = event match {
-    case stateChangeEvent: StateChangeEvent => 
genericSerializer.serialize(stateChangeEvent)
-  }
+  override def toJson(event: Event): String = 
genericSerializer.serialize(event)
 
   override def asEvent(serialized: String): Event = 
genericSerializer.deserialize(serialized)
 
-  override def toJsonBytes(event: Event): Array[Byte] =  event match {
-    case stateChangeEvent: StateChangeEvent => 
genericSerializer.serializeToBytes(stateChangeEvent)
-  }
+  override def toJsonBytes(event: Event): Array[Byte] =  
genericSerializer.serializeToBytes(event)
 
   override def fromBytes(serialized: Array[Byte]): Event = 
genericSerializer.deserializeFromBytes(serialized)
 }


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org

Reply via email to