chibenwa commented on code in PR #2479: URL: https://github.com/apache/james-project/pull/2479#discussion_r1824107136
########## server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/routes/WebSocketRoutes.scala: ########## @@ -79,7 +80,12 @@ class WebSocketRoutes @Inject() (@Named(InjectionKeys.RFC_8621) val authenticato emailChangeRepository: EmailChangeRepository, pushSerializer: PushSerializer, typeStateFactory: TypeStateFactory, - delegationStore: DelegationStore) extends JMAPRoutes { + delegationStore: DelegationStore, + metricFactory: MetricFactory, + gaugeRegistry: GaugeRegistry) extends JMAPRoutes { + private val openingConnectionsMetric: Metric = metricFactory.generate("jmap_websocket_opening_connections") Review Comment: ```suggestion private val openingConnectionsMetric: Metric = metricFactory.generate("jmap_websocket_opened_connections_count") ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For additional commands, e-mail: notifications-h...@james.apache.org