(james-project) 01/02: JAMES-3954 Add more details on PartialRange validity

[rcordier]

This is an automated email from the ASF dual-hosted git repository.

rcordier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git

commit 2a904b0b32cd76669bb631a03537379bdcede97b
Author: Benoit TELLIER <btell...@linagora.com>
AuthorDate: Thu Oct 31 10:32:09 2024 +0100

    JAMES-3954 Add more details on PartialRange validity
---
 .../org/apache/james/imap/api/message/PartialRange.java     | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git 
a/protocols/imap/src/main/java/org/apache/james/imap/api/message/PartialRange.java
 
b/protocols/imap/src/main/java/org/apache/james/imap/api/message/PartialRange.java
index eb0c2e575d..ccdd04da3a 100644
--- 
a/protocols/imap/src/main/java/org/apache/james/imap/api/message/PartialRange.java
+++ 
b/protocols/imap/src/main/java/org/apache/james/imap/api/message/PartialRange.java
@@ -29,17 +29,18 @@ public class PartialRange {
     private final long upVal;
 
     public PartialRange(long lowVal, long upVal) throws DecodingException {
-        checkArgument(lowVal != 0);
-        checkArgument(upVal != 0);
-        checkArgument(lowVal > 0 == upVal > 0);
-        checkArgument(Math.abs(lowVal) <= Math.abs(upVal));
+        checkArgument(lowVal != 0, "'lowVal' cannot be equal to 0");
+        checkArgument(upVal != 0, "'upVal' cannot be equal to 0");
+        checkArgument(lowVal > 0 == upVal > 0, "Both 'upVal' and 'lowVal' must 
have the same sign, got lowVal=" + lowVal + " and upVal=" + upVal);
+        checkArgument(Math.abs(lowVal) <= Math.abs(upVal),
+            "'lowVal' absolute value must lower than upVal absolute value, got 
lowVal=" + lowVal + " and upVal=" + upVal);
         this.lowVal = lowVal;
         this.upVal = upVal;
     }
 
-    public void checkArgument(boolean condition) throws DecodingException {
+    public void checkArgument(boolean condition, String explanation) throws 
DecodingException {
         if (!condition) {
-            throw new DecodingException(HumanReadableText.ILLEGAL_ARGUMENTS, 
"Invalid partial range");
+            throw new DecodingException(HumanReadableText.ILLEGAL_ARGUMENTS, 
"Invalid partial range: " + explanation);
         }
     }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org