quantranhong1999 commented on code in PR #2483:
URL: https://github.com/apache/james-project/pull/2483#discussion_r1825533116
##########
server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/routes/SessionRoutes.scala:
##########
@@ -73,6 +75,7 @@ class SessionRoutes @Inject()(@Named(InjectionKeys.RFC_8621)
val authenticator:
.flatMap(session => sendRespond(session, response))
.onErrorResume(throwable => SMono.fromPublisher(errorHandling(throwable,
response)))
.asJava()
+ .doOnSuccess(_ => httpClientMetrics.update())
Review Comment:
Trigger the polling update upon successful GET `/jmap/session` seems ok IMO.
While it could be a bit much doing it at POST `/jmap` (or we could add some
random).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org
