chibenwa opened a new pull request, #2486:
URL: https://github.com/apache/james-project/pull/2486
The ReactiveThrottler can be (subscriber direct) recursive, leading to
StackOverflowError that could cause unpredictable failure.
Very rare yet spotted in production twice in a row, effectively killing the
IMAP service:
```
java.lang.StackOverflowError: null
at java.base/java.text.DecimalFormat.format(Unknown Source)
at java.base/java.text.DecimalFormat.format(Unknown Source)
at java.base/java.text.SimpleDateFormat.zeroPaddingNumber(Unknown
Source)
at java.base/java.text.SimpleDateFormat.subFormat(Unknown Source)
at java.base/java.text.SimpleDateFormat.format(Unknown Source)
at java.base/java.text.SimpleDateFormat.format(Unknown Source)
at java.base/java.text.DateFormat.format(Unknown Source)
at ch.qos.logback.contrib.json.JsonLayoutBase.format(Unknown Source)
at ch.qos.logback.contrib.json.JsonLayoutBase.formatTimestamp(Unknown
Source)
at ch.qos.logback.contrib.json.JsonLayoutBase.addTimestamp(Unknown
Source)
at ch.qos.logback.contrib.json.classic.JsonLayout.toJsonMap(Unknown
Source)
at ch.qos.logback.contrib.json.classic.JsonLayout.toJsonMap(Unknown
Source)
at ch.qos.logback.contrib.json.JsonLayoutBase.doLayout(Unknown Source)
at
ch.qos.logback.core.encoder.LayoutWrappingEncoder.encode(LayoutWrappingEncoder.java:114)
at
ch.qos.logback.core.OutputStreamAppender.writeOut(OutputStreamAppender.java:192)
at
ch.qos.logback.core.OutputStreamAppender.subAppend(OutputStreamAppender.java:237)
at
ch.qos.logback.core.OutputStreamAppender.append(OutputStreamAppender.java:102)
at
ch.qos.logback.core.UnsynchronizedAppenderBase.doAppend(UnsynchronizedAppenderBase.java:85)
at
ch.qos.logback.core.spi.AppenderAttachableImpl.appendLoopOnAppenders(AppenderAttachableImpl.java:51)
at ch.qos.logback.classic.Logger.appendLoopOnAppenders(Logger.java:272)
at ch.qos.logback.classic.Logger.callAppenders(Logger.java:259)
at
ch.qos.logback.classic.Logger.buildLoggingEventAndAppend(Logger.java:426)
at ch.qos.logback.classic.Logger.filterAndLog_0_Or3Plus(Logger.java:386)
at ch.qos.logback.classic.Logger.warn(Logger.java:697)
at reactor.util.Loggers$Slf4JLogger.warn(Loggers.java:304)
at reactor.core.Exceptions.throwIfFatal(Exceptions.java:513)
at reactor.core.publisher.Operators.onOperatorError(Operators.java:756)
at reactor.core.publisher.Operators.onOperatorError(Operators.java:734)
at reactor.core.publisher.Operators.onOperatorError(Operators.java:716)
at
reactor.core.publisher.Operators.reportThrowInSubscribe(Operators.java:232)
at reactor.core.publisher.Mono.subscribe(Mono.java:4571)
at reactor.core.publisher.Mono.subscribeWith(Mono.java:4634)
at reactor.core.publisher.Mono.subscribe(Mono.java:4395)
at
org.apache.james.imapserver.netty.ReactiveThrottler.onRequestDone(ReactiveThrottler.java:129)
at
org.apache.james.imapserver.netty.ReactiveThrottler.lambda$onRequestDone$5(ReactiveThrottler.java:127)
at
reactor.core.publisher.FluxDoFinally$DoFinallySubscriber.runFinally(FluxDoFinally.java:146)
at
reactor.core.publisher.FluxDoFinally$DoFinallySubscriber.onComplete(FluxDoFinally.java:129)
at
reactor.core.publisher.MonoIgnoreThen$ThenIgnoreMain.onComplete(MonoIgnoreThen.java:210)
at
reactor.core.publisher.MonoIgnoreThen$ThenIgnoreMain.subscribeNext(MonoIgnoreThen.java:239)
at
reactor.core.publisher.MonoIgnoreThen$ThenIgnoreMain.onComplete(MonoIgnoreThen.java:204)
at
reactor.core.publisher.FluxContextWrite$ContextWriteSubscriber.onComplete(FluxContextWrite.java:126)
at
reactor.core.publisher.FluxDoOnEach$DoOnEachSubscriber.onComplete(FluxDoOnEach.java:223)
at
reactor.core.publisher.FluxContextWrite$ContextWriteSubscriber.onComplete(FluxContextWrite.java:126)
at
reactor.core.publisher.MonoUsing$MonoUsingSubscriber.onComplete(MonoUsing.java:283)
at
reactor.core.publisher.Operators$MultiSubscriptionSubscriber.onComplete(Operators.java:2231)
at
reactor.core.publisher.Operators$MultiSubscriptionSubscriber.onComplete(Operators.java:2231)
at
reactor.core.publisher.Operators$MultiSubscriptionSubscriber.onComplete(Operators.java:2231)
at
reactor.core.publisher.MonoIgnoreThen$ThenIgnoreMain.onComplete(MonoIgnoreThen.java:210)
at
reactor.core.publisher.MonoIgnoreThen$ThenIgnoreMain.subscribeNext(MonoIgnoreThen.java:239)
at
reactor.core.publisher.MonoIgnoreThen.subscribe(MonoIgnoreThen.java:51)
at
reactor.core.publisher.InternalMonoOperator.subscribe(InternalMonoOperator.java:76)
at reactor.core.publisher.MonoUsing.subscribe(MonoUsing.java:109)
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org
