This is an automated email from the ASF dual-hosted git repository.
rcordier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git
commit a72f2d2463951de083ba017f915fa460360e19b3
Author: Quan Tran <hqt...@linagora.com>
AuthorDate: Thu Nov 7 14:08:15 2024 +0700
JAMES-4038 Improve invalid hostname log
The `dot` ends the sentence could be mixed as a part of the invalid EHLO
argument.
---
.../java/org/apache/james/protocols/smtp/core/esmtp/EhloCmdHandler.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/core/esmtp/EhloCmdHandler.java
b/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/core/esmtp/EhloCmdHandler.java
index 85ade34463..3af6fb6c64 100644
---
a/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/core/esmtp/EhloCmdHandler.java
+++
b/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/core/esmtp/EhloCmdHandler.java
@@ -82,7 +82,7 @@ public class EhloCmdHandler extends
AbstractHookableCmdHandler<HeloHook> impleme
*/
private Response doEHLO(SMTPSession session, String argument) {
if (!isValid(argument)) {
- LOGGER.error("Invalid EHLO argument received: {}. Must be a domain
name or an IP address.", argument);
+ LOGGER.error("Invalid EHLO argument received: {} which must be a
domain name or an IP address.", argument);
return new SMTPResponse(SMTPRetCode.SYNTAX_ERROR_ARGUMENTS,
DSNStatus.getStatus(DSNStatus.PERMANENT,
DSNStatus.DELIVERY_SYNTAX) + " Invalid domain name or ip supplied as HELO
argument");
}
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org
