HoussemNasri commented on code in PR #2493:
URL: https://github.com/apache/james-project/pull/2493#discussion_r1836697131
##########
server/blob/blob-s3/src/main/java/org/apache/james/blob/objectstorage/aws/sse/S3SSECustomerKeyFactory.java:
##########
@@ -51,4 +52,20 @@ public Mono<SSECustomerKey> generate(BucketName bucketName,
BlobId blobId) {
return Mono.just(sseCustomerKey);
}
}
+
+ class PerObjectCustomerKeyFactory implements S3SSECustomerKeyFactory {
Review Comment:
What is the idea behind this class name? I expected a mention of the derived
key given that the class takes `S3SSECConfiguration.KeyDerivationEnabled` as an
argument.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org
