vttranlina commented on code in PR #2503:
URL: https://github.com/apache/james-project/pull/2503#discussion_r1841558313


##########
mailbox/store/src/main/java/org/apache/james/mailbox/store/StoreMailboxManager.java:
##########
@@ -454,7 +454,12 @@ private Mono<MailboxPath> 
nearestExistingParent(MailboxSession session, MailboxP
     private Mono<Void> inheritRightsReactive(MailboxSession mailboxSession, 
MailboxPath path) {
         return nearestExistingParent(mailboxSession, path)
             .flatMap(parent -> Mono.from(listRightsReactive(parent, 
mailboxSession)))
-            .flatMap(acl -> 
storeRightManager.setRightsReactiveWithoutAccessControl(path, acl, 
mailboxSession));
+            .flatMap(acl -> {
+                if (acl.getEntries().isEmpty()) {
+                    return Mono.empty();
+                }

Review Comment:
   `acl.getEntries().isEmpty()` is very clear to me



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org

Reply via email to