chibenwa commented on code in PR #2482:
URL: https://github.com/apache/james-project/pull/2482#discussion_r1846660365
##########
pom.xml:
##########
@@ -2078,11 +2078,15 @@
<groupId>ch.qos.logback.contrib</groupId>
<artifactId>logback-jackson</artifactId>
<version>0.1.5</version>
+ <scope>system</scope>
+
<systemPath>${project.basedir}/root/libs/logback-jackson-0.1.5.jar</systemPath>
Review Comment:
Remove to not mean add the linagora specific lib as a magic jar depedency.
BTW binary is not reviewable source code and do not meet ASF standards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org
