chibenwa commented on code in PR #2560:
URL: https://github.com/apache/james-project/pull/2560#discussion_r1877508385
##########
protocols/pop3/src/main/java/org/apache/james/protocols/pop3/core/UserCmdHandler.java:
##########
@@ -70,9 +70,13 @@ private Response user(POP3Session session, Request request) {
LOGGER.trace("USER command received");
String parameters = request.getArgument();
if (session.getHandlerState() == POP3Session.AUTHENTICATION_READY &&
parameters != null) {
- session.setUsername(Username.of(parameters));
- session.setHandlerState(POP3Session.AUTHENTICATION_USERSET);
- return POP3Response.OK;
+ try {
+ session.setUsername(Username.of(parameters));
+ session.setHandlerState(POP3Session.AUTHENTICATION_USERSET);
+ return POP3Response.OK;
+ } catch (IllegalArgumentException e) {
+ return POP3Response.ERR;
Review Comment:
info log here please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org
