Re: [PR] JAMES-3491 - JMAP WebSockets - support ping interval [james-project]

[via GitHub]

chibenwa commented on PR #2561:
URL: https://github.com/apache/james-project/pull/2561#issuecomment-2530709338

   "Diving into it, reactor-netty seems to have a proxyPing option to answer 
ping by itself:
   
   
![image](https://github.com/user-attachments/assets/f95afc14-7578-45b3-b117-70c85363319c)
   
   
   CF 
   
   ```
     private def handleWebSockets(httpServerRequest: HttpServerRequest, 
httpServerResponse: HttpServerResponse): Mono[Void] = {
       SMono(authenticator.authenticate(httpServerRequest))
         .flatMap((mailboxSession: MailboxSession) => 
userProvisioner.provisionUser(mailboxSession)
           .`then`
           
.`then`(SMono(httpServerResponse.addHeader(HttpHeaderNames.SEC_WEBSOCKET_PROTOCOL,
 "jmap")
             .sendWebsocket(handleWebSocketConnection(mailboxSession),
               WebsocketServerSpec.builder
                 .handlePing(true)
                 .build))
             .doOnSubscribe(_ => openingConnectionsMetric.increment())
             .doOnTerminate(() => openingConnectionsMetric.decrement())))
         .onErrorResume(throwable => handleHttpHandshakeError(throwable, 
httpServerResponse))
         .asJava()
         .`then`()
     }
   ```
   
   Please explore that option too (client PING, answered by the server.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org