chibenwa commented on code in PR #2582:
URL: https://github.com/apache/james-project/pull/2582#discussion_r1898816817
##########
server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/delivery/MailDispatcher.java:
##########
@@ -198,11 +199,15 @@ private Mono<Void> storeMailWithRetry(Mail mail,
MailAddress recipient) {
AtomicInteger remainRetries = new AtomicInteger(retries.orElse(0));
Mono<Void> operation = Mono.from(mailStore.storeMail(recipient, mail))
- .doOnError(error -> LOGGER.warn("Error While storing mail. This
error will be retried for {} more times.", remainRetries.getAndDecrement(),
error));
+ .doOnError(OverQuotaException.class, e -> LOGGER.info("Could not
store mail due to quota error", e))
Review Comment:
```suggestion
.doOnError(OverQuotaException.class, e -> LOGGER.info("Could not
store mail due to quota error fur user {}", user))
```
-> let's have the user it is functionally important
I am not convinced of the need log th full stacktrace in an info log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org
