chibenwa commented on code in PR #2605:
URL: https://github.com/apache/james-project/pull/2605#discussion_r1917991293
##########
server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/method/EmailSetDeletePerformer.scala:
##########
@@ -119,5 +118,6 @@ class EmailSetDeletePerformer @Inject()(messageIdManager:
MessageIdManager,
.map(_.asString())
.getOrElse("")))
.log("Mails deleted."))
+ .subscribe()
Review Comment:
Please let's not break the reactive chain. Return a SMono here.
Idem here and in other places.
Or remove the uneeded logAsMono (just log directly) that is not usefull as
it is not plugged to upstream MDC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org
