Re: [PR] JAMES-4100 Improve Search Snippet display [james-project]

[via GitHub]

chibenwa commented on code in PR #2583:
URL: https://github.com/apache/james-project/pull/2583#discussion_r1922179985


##########
mailbox/opensearch/src/main/java/org/apache/james/mailbox/opensearch/json/IndexableMessage.java:
##########
@@ -135,8 +135,8 @@ private Mono<IndexableMessage> instantiateIndexedMessage() 
throws IOException, M
                 .asMimePart(textExtractor)
                 .map(parsingResult -> {
 
-                    Optional<String> bodyText = 
parsingResult.locateFirstTextBody();
-                    Optional<String> bodyHtml = 
parsingResult.locateFirstHtmlBody();
+                    Optional<String> bodyText = 
parsingResult.locateFirstTextBody().map(SearchUtil::removeGreaterThanCharacters);
+                    Optional<String> bodyHtml = 
parsingResult.locateFirstHtmlBody().map(SearchUtil::removeGreaterThanCharacters);

Review Comment:
   Take this message:
   
   
![image](https://github.com/user-attachments/assets/93a08bb5-fd7c-49c2-8a84-ba3e90f137a2)
   
   The corresponding HTML body is:
   
   
![image](https://github.com/user-attachments/assets/60be5590-a4a5-487e-89c2-8f209c1e62e8)
   
   Which do not quote with `>...` but with `<blockquote>...</blockquote>` so 
removing `>>>` at the beginning of line for `text/html` is indeed a non-sense 
with well-formatted non testing data.
   
   Can you provide us with real world data where removing `>>>` for HTML body 
makes sense?
    
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org