(james-project) branch master updated: [devscout] adds missing binding for S3RequestOption (#2607)

[btellier]

This is an automated email from the ASF dual-hosted git repository.

btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git


The following commit(s) were added to refs/heads/master by this push:
     new 853de14331 [devscout] adds missing binding for S3RequestOption (#2607)
853de14331 is described below

commit 853de143317fb4f77c41a6da7e90d6ea47500fb7
Author: Jean Helou <j...@xn--gml-cma.com>
AuthorDate: Wed Jan 22 09:07:27 2025 +0100

    [devscout] adds missing binding for S3RequestOption (#2607)
    
    this prevents the scaling pulsar smtp assembly from starting. This is not 
detected by tests because the  AwsS3BlobStoreExtension injects the 
awsS3TestRule's module which does inject the default option in scope.
---
 .../apps/scaling-pulsar-smtp/src/main/java/org/apache/james/Main.java   | 2 ++
 1 file changed, 2 insertions(+)

diff --git 
a/server/apps/scaling-pulsar-smtp/src/main/java/org/apache/james/Main.java 
b/server/apps/scaling-pulsar-smtp/src/main/java/org/apache/james/Main.java
index a4b5052928..71401164e2 100644
--- a/server/apps/scaling-pulsar-smtp/src/main/java/org/apache/james/Main.java
+++ b/server/apps/scaling-pulsar-smtp/src/main/java/org/apache/james/Main.java
@@ -23,6 +23,7 @@ import org.apache.james.blob.api.BlobStore;
 import org.apache.james.blob.api.BlobStoreDAO;
 import org.apache.james.blob.api.MetricableBlobStore;
 import org.apache.james.blob.objectstorage.aws.S3BlobStoreDAO;
+import org.apache.james.blob.objectstorage.aws.S3RequestOption;
 import org.apache.james.mailrepository.api.MailRepositoryUrlStore;
 import org.apache.james.mailrepository.jpa.JPAMailRepositoryUrlStore;
 import org.apache.james.modules.RunArgumentsModule;
@@ -71,6 +72,7 @@ public class Main implements JamesServerMain {
         new S3BlobStoreModule(),
         new S3BucketModule(),
         binder -> {
+            
binder.bind(S3RequestOption.class).toInstance(S3RequestOption.DEFAULT);
             binder.bind(BlobStoreDAO.class).to(S3BlobStoreDAO.class)
                 .in(Scopes.SINGLETON);
             binder.bind(BlobStore.class)


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org