This is an automated email from the ASF dual-hosted git repository. btellier pushed a commit to branch 3.8.x in repository https://gitbox.apache.org/repos/asf/james-project.git
commit 70dadee2646c588c11b1072f5340b3273b29010c Author: Quan Tran <hqt...@linagora.com> AuthorDate: Thu Jan 23 13:22:46 2025 +0700 Move JsoupHtmlTextExtractor to JMAP RFC-8621 module --- .../src/main/java/org/apache/james/jmap/draft/JMAPModule.java | 2 +- server/protocols/jmap-draft/pom.xml | 9 +++++---- .../james/jmap/MessageFastViewProjectionItemFactoryTest.java | 2 +- .../src/test/java/org/apache/james/jmap/PreviewFactoryTest.java | 2 +- .../apache/james/jmap/draft/methods/GetMessagesMethodTest.java | 2 +- .../org/apache/james/jmap/draft/methods/MessageSenderTest.java | 2 +- .../jmap/draft/methods/SetMessagesCreationProcessorTest.java | 2 +- .../draft/model/message/view/MessageFastViewFactoryTest.java | 2 +- .../draft/model/message/view/MessageFullViewFactoryTest.java | 2 +- .../jmap/event/ComputeMessageFastViewProjectionListenerTest.java | 2 +- server/protocols/jmap-rfc-8621/pom.xml | 4 ++++ .../org/apache/james/jmap}/utils/JsoupHtmlTextExtractor.java | 4 ++-- .../org/apache/james/jmap}/utils/JsoupHtmlTextExtractorTest.java | 2 +- .../src/test/resources/example.html | 0 server/protocols/webadmin/webadmin-jmap/pom.xml | 5 +++++ .../RecomputeAllFastViewProjectionItemsRequestToTaskTest.java | 2 +- .../RecomputeUserFastViewProjectionItemsRequestToTaskTest.java | 2 +- 17 files changed, 28 insertions(+), 18 deletions(-) diff --git a/server/container/guice/protocols/jmap/src/main/java/org/apache/james/jmap/draft/JMAPModule.java b/server/container/guice/protocols/jmap/src/main/java/org/apache/james/jmap/draft/JMAPModule.java index 2f43328ffe..005a1dfa8e 100644 --- a/server/container/guice/protocols/jmap/src/main/java/org/apache/james/jmap/draft/JMAPModule.java +++ b/server/container/guice/protocols/jmap/src/main/java/org/apache/james/jmap/draft/JMAPModule.java @@ -50,9 +50,9 @@ import org.apache.james.jmap.core.VacationResponseCapabilityFactory$; import org.apache.james.jmap.core.WebSocketCapabilityFactory$; import org.apache.james.jmap.draft.methods.RequestHandler; import org.apache.james.jmap.draft.send.PostDequeueDecoratorFactory; -import org.apache.james.jmap.draft.utils.JsoupHtmlTextExtractor; import org.apache.james.jmap.mailet.filter.JMAPFiltering; import org.apache.james.jmap.rfc8621.RFC8621MethodsModule; +import org.apache.james.jmap.utils.JsoupHtmlTextExtractor; import org.apache.james.jwt.JwtConfiguration; import org.apache.james.jwt.JwtTokenVerifier; import org.apache.james.lifecycle.api.StartUpCheck; diff --git a/server/protocols/jmap-draft/pom.xml b/server/protocols/jmap-draft/pom.xml index baa2748df2..06add72964 100644 --- a/server/protocols/jmap-draft/pom.xml +++ b/server/protocols/jmap-draft/pom.xml @@ -121,6 +121,11 @@ <artifactId>james-server-jmap</artifactId> <version>${project.version}</version> </dependency> + <dependency> + <groupId>${james.groupId}</groupId> + <artifactId>james-server-jmap-rfc-8621</artifactId> + <scope>test</scope> + </dependency> <dependency> <groupId>${james.groupId}</groupId> <artifactId>james-server-jwt</artifactId> @@ -268,10 +273,6 @@ <artifactId>jgrapht-core</artifactId> <version>1.5.1</version> </dependency> - <dependency> - <groupId>org.jsoup</groupId> - <artifactId>jsoup</artifactId> - </dependency> <dependency> <groupId>org.junit.platform</groupId> <artifactId>junit-platform-engine</artifactId> diff --git a/server/protocols/jmap-draft/src/test/java/org/apache/james/jmap/MessageFastViewProjectionItemFactoryTest.java b/server/protocols/jmap-draft/src/test/java/org/apache/james/jmap/MessageFastViewProjectionItemFactoryTest.java index f3a06904c2..40665c2fa9 100644 --- a/server/protocols/jmap-draft/src/test/java/org/apache/james/jmap/MessageFastViewProjectionItemFactoryTest.java +++ b/server/protocols/jmap-draft/src/test/java/org/apache/james/jmap/MessageFastViewProjectionItemFactoryTest.java @@ -24,7 +24,7 @@ import static org.assertj.core.api.Assertions.assertThat; import org.apache.james.core.Username; import org.apache.james.jmap.api.model.Preview; import org.apache.james.jmap.api.projections.MessageFastViewPrecomputedProperties; -import org.apache.james.jmap.draft.utils.JsoupHtmlTextExtractor; +import org.apache.james.jmap.utils.JsoupHtmlTextExtractor; import org.apache.james.mailbox.MailboxManager; import org.apache.james.mailbox.MailboxSession; import org.apache.james.mailbox.MessageManager; diff --git a/server/protocols/jmap-draft/src/test/java/org/apache/james/jmap/PreviewFactoryTest.java b/server/protocols/jmap-draft/src/test/java/org/apache/james/jmap/PreviewFactoryTest.java index f55ff31ece..311c5d6484 100644 --- a/server/protocols/jmap-draft/src/test/java/org/apache/james/jmap/PreviewFactoryTest.java +++ b/server/protocols/jmap-draft/src/test/java/org/apache/james/jmap/PreviewFactoryTest.java @@ -22,7 +22,7 @@ package org.apache.james.jmap; import static org.assertj.core.api.Assertions.assertThat; import org.apache.james.jmap.api.model.Preview; -import org.apache.james.jmap.draft.utils.JsoupHtmlTextExtractor; +import org.apache.james.jmap.utils.JsoupHtmlTextExtractor; import org.apache.james.util.ClassLoaderUtils; import org.apache.james.util.mime.MessageContentExtractor; import org.junit.jupiter.api.BeforeEach; diff --git a/server/protocols/jmap-draft/src/test/java/org/apache/james/jmap/draft/methods/GetMessagesMethodTest.java b/server/protocols/jmap-draft/src/test/java/org/apache/james/jmap/draft/methods/GetMessagesMethodTest.java index 9a3c73a210..3cf7fa41ed 100644 --- a/server/protocols/jmap-draft/src/test/java/org/apache/james/jmap/draft/methods/GetMessagesMethodTest.java +++ b/server/protocols/jmap-draft/src/test/java/org/apache/james/jmap/draft/methods/GetMessagesMethodTest.java @@ -49,8 +49,8 @@ import org.apache.james.jmap.draft.model.message.view.MessageHeaderViewFactory; import org.apache.james.jmap.draft.model.message.view.MessageMetadataView; import org.apache.james.jmap.draft.model.message.view.MessageMetadataViewFactory; import org.apache.james.jmap.draft.model.message.view.MetaMessageViewFactory; -import org.apache.james.jmap.draft.utils.JsoupHtmlTextExtractor; import org.apache.james.jmap.memory.projections.MemoryMessageFastViewProjection; +import org.apache.james.jmap.utils.JsoupHtmlTextExtractor; import org.apache.james.mailbox.FlagsBuilder; import org.apache.james.mailbox.MailboxSession; import org.apache.james.mailbox.MailboxSessionUtil; diff --git a/server/protocols/jmap-draft/src/test/java/org/apache/james/jmap/draft/methods/MessageSenderTest.java b/server/protocols/jmap-draft/src/test/java/org/apache/james/jmap/draft/methods/MessageSenderTest.java index d45c0a2f8b..e7ebbaf2b4 100644 --- a/server/protocols/jmap-draft/src/test/java/org/apache/james/jmap/draft/methods/MessageSenderTest.java +++ b/server/protocols/jmap-draft/src/test/java/org/apache/james/jmap/draft/methods/MessageSenderTest.java @@ -37,8 +37,8 @@ import org.apache.james.jmap.draft.model.Keywords; import org.apache.james.jmap.draft.model.message.view.MessageFullView; import org.apache.james.jmap.draft.model.message.view.MessageFullViewFactory; import org.apache.james.jmap.draft.model.message.view.MessageFullViewFactory.MetaDataWithContent; -import org.apache.james.jmap.draft.utils.JsoupHtmlTextExtractor; import org.apache.james.jmap.memory.projections.MemoryMessageFastViewProjection; +import org.apache.james.jmap.utils.JsoupHtmlTextExtractor; import org.apache.james.mailbox.MessageIdManager; import org.apache.james.mailbox.MessageUid; import org.apache.james.mailbox.inmemory.InMemoryId; diff --git a/server/protocols/jmap-draft/src/test/java/org/apache/james/jmap/draft/methods/SetMessagesCreationProcessorTest.java b/server/protocols/jmap-draft/src/test/java/org/apache/james/jmap/draft/methods/SetMessagesCreationProcessorTest.java index 1db876ea72..81af124629 100644 --- a/server/protocols/jmap-draft/src/test/java/org/apache/james/jmap/draft/methods/SetMessagesCreationProcessorTest.java +++ b/server/protocols/jmap-draft/src/test/java/org/apache/james/jmap/draft/methods/SetMessagesCreationProcessorTest.java @@ -52,8 +52,8 @@ import org.apache.james.jmap.draft.model.SetMessagesResponse; import org.apache.james.jmap.draft.model.message.view.MessageFullViewFactory; import org.apache.james.jmap.draft.send.MailMetadata; import org.apache.james.jmap.draft.send.MailSpool; -import org.apache.james.jmap.draft.utils.JsoupHtmlTextExtractor; import org.apache.james.jmap.memory.projections.MemoryMessageFastViewProjection; +import org.apache.james.jmap.utils.JsoupHtmlTextExtractor; import org.apache.james.mailbox.AttachmentManager; import org.apache.james.mailbox.MailboxManager; import org.apache.james.mailbox.MailboxSession; diff --git a/server/protocols/jmap-draft/src/test/java/org/apache/james/jmap/draft/model/message/view/MessageFastViewFactoryTest.java b/server/protocols/jmap-draft/src/test/java/org/apache/james/jmap/draft/model/message/view/MessageFastViewFactoryTest.java index b49c194f19..a9d75a702e 100644 --- a/server/protocols/jmap-draft/src/test/java/org/apache/james/jmap/draft/model/message/view/MessageFastViewFactoryTest.java +++ b/server/protocols/jmap-draft/src/test/java/org/apache/james/jmap/draft/model/message/view/MessageFastViewFactoryTest.java @@ -46,9 +46,9 @@ import org.apache.james.jmap.draft.model.Keyword; import org.apache.james.jmap.draft.model.Keywords; import org.apache.james.jmap.draft.model.Number; import org.apache.james.jmap.draft.model.PreviewDTO; -import org.apache.james.jmap.draft.utils.JsoupHtmlTextExtractor; import org.apache.james.jmap.memory.projections.MemoryMessageFastViewProjection; import org.apache.james.jmap.memory.upload.InMemoryUploadRepository; +import org.apache.james.jmap.utils.JsoupHtmlTextExtractor; import org.apache.james.mailbox.MailboxSession; import org.apache.james.mailbox.MessageIdManager; import org.apache.james.mailbox.MessageManager; diff --git a/server/protocols/jmap-draft/src/test/java/org/apache/james/jmap/draft/model/message/view/MessageFullViewFactoryTest.java b/server/protocols/jmap-draft/src/test/java/org/apache/james/jmap/draft/model/message/view/MessageFullViewFactoryTest.java index fe21a6f239..42cb727477 100644 --- a/server/protocols/jmap-draft/src/test/java/org/apache/james/jmap/draft/model/message/view/MessageFullViewFactoryTest.java +++ b/server/protocols/jmap-draft/src/test/java/org/apache/james/jmap/draft/model/message/view/MessageFullViewFactoryTest.java @@ -54,9 +54,9 @@ import org.apache.james.jmap.draft.model.Keywords; import org.apache.james.jmap.draft.model.Number; import org.apache.james.jmap.draft.model.PreviewDTO; import org.apache.james.jmap.draft.model.message.view.MessageFullViewFactory.MetaDataWithContent; -import org.apache.james.jmap.draft.utils.JsoupHtmlTextExtractor; import org.apache.james.jmap.memory.projections.MemoryMessageFastViewProjection; import org.apache.james.jmap.memory.upload.InMemoryUploadRepository; +import org.apache.james.jmap.utils.JsoupHtmlTextExtractor; import org.apache.james.mailbox.MailboxSession; import org.apache.james.mailbox.MessageIdManager; import org.apache.james.mailbox.MessageManager; diff --git a/server/protocols/jmap-draft/src/test/java/org/apache/james/jmap/event/ComputeMessageFastViewProjectionListenerTest.java b/server/protocols/jmap-draft/src/test/java/org/apache/james/jmap/event/ComputeMessageFastViewProjectionListenerTest.java index 5c7f07443e..01c5859ae5 100644 --- a/server/protocols/jmap-draft/src/test/java/org/apache/james/jmap/event/ComputeMessageFastViewProjectionListenerTest.java +++ b/server/protocols/jmap-draft/src/test/java/org/apache/james/jmap/event/ComputeMessageFastViewProjectionListenerTest.java @@ -43,9 +43,9 @@ import org.apache.james.jmap.api.projections.MessageFastViewPrecomputedPropertie import org.apache.james.jmap.api.projections.MessageFastViewProjection; import org.apache.james.jmap.draft.methods.BlobManagerImpl; import org.apache.james.jmap.draft.model.message.view.MessageFullViewFactory; -import org.apache.james.jmap.draft.utils.JsoupHtmlTextExtractor; import org.apache.james.jmap.memory.projections.MemoryMessageFastViewProjection; import org.apache.james.jmap.memory.upload.InMemoryUploadRepository; +import org.apache.james.jmap.utils.JsoupHtmlTextExtractor; import org.apache.james.mailbox.MailboxSession; import org.apache.james.mailbox.MailboxSessionUtil; import org.apache.james.mailbox.MessageIdManager; diff --git a/server/protocols/jmap-rfc-8621/pom.xml b/server/protocols/jmap-rfc-8621/pom.xml index 5c42aba996..10c9218b8a 100644 --- a/server/protocols/jmap-rfc-8621/pom.xml +++ b/server/protocols/jmap-rfc-8621/pom.xml @@ -159,6 +159,10 @@ <artifactId>json-unit-assertj</artifactId> <scope>test</scope> </dependency> + <dependency> + <groupId>org.jsoup</groupId> + <artifactId>jsoup</artifactId> + </dependency> <dependency> <groupId>org.mock-server</groupId> <artifactId>mockserver-netty</artifactId> diff --git a/server/protocols/jmap-draft/src/main/java/org/apache/james/jmap/draft/utils/JsoupHtmlTextExtractor.java b/server/protocols/jmap-rfc-8621/src/main/java/org/apache/james/jmap/utils/JsoupHtmlTextExtractor.java similarity index 98% rename from server/protocols/jmap-draft/src/main/java/org/apache/james/jmap/draft/utils/JsoupHtmlTextExtractor.java rename to server/protocols/jmap-rfc-8621/src/main/java/org/apache/james/jmap/utils/JsoupHtmlTextExtractor.java index 41fbe88b65..f84c5e0c88 100644 --- a/server/protocols/jmap-draft/src/main/java/org/apache/james/jmap/draft/utils/JsoupHtmlTextExtractor.java +++ b/server/protocols/jmap-rfc-8621/src/main/java/org/apache/james/jmap/utils/JsoupHtmlTextExtractor.java @@ -1,5 +1,5 @@ /**************************************************************** - O * Licensed to the Apache Software Foundation (ASF) under one * + * Licensed to the Apache Software Foundation (ASF) under one * * or more contributor license agreements. See the NOTICE file * * distributed with this work for additional information * * regarding copyright ownership. The ASF licenses this file * @@ -17,7 +17,7 @@ * under the License. * ****************************************************************/ -package org.apache.james.jmap.draft.utils; +package org.apache.james.jmap.utils; import java.util.Deque; import java.util.Optional; diff --git a/server/protocols/jmap-draft/src/test/java/org/apache/james/jmap/draft/utils/JsoupHtmlTextExtractorTest.java b/server/protocols/jmap-rfc-8621/src/test/java/org/apache/james/jmap/utils/JsoupHtmlTextExtractorTest.java similarity index 99% rename from server/protocols/jmap-draft/src/test/java/org/apache/james/jmap/draft/utils/JsoupHtmlTextExtractorTest.java rename to server/protocols/jmap-rfc-8621/src/test/java/org/apache/james/jmap/utils/JsoupHtmlTextExtractorTest.java index 4829c00c43..685e0f1ee8 100644 --- a/server/protocols/jmap-draft/src/test/java/org/apache/james/jmap/draft/utils/JsoupHtmlTextExtractorTest.java +++ b/server/protocols/jmap-rfc-8621/src/test/java/org/apache/james/jmap/utils/JsoupHtmlTextExtractorTest.java @@ -17,7 +17,7 @@ * under the License. * ****************************************************************/ -package org.apache.james.jmap.draft.utils; +package org.apache.james.jmap.utils; import static org.assertj.core.api.Assertions.assertThat; diff --git a/server/protocols/jmap-draft/src/test/resources/example.html b/server/protocols/jmap-rfc-8621/src/test/resources/example.html similarity index 100% rename from server/protocols/jmap-draft/src/test/resources/example.html rename to server/protocols/jmap-rfc-8621/src/test/resources/example.html diff --git a/server/protocols/webadmin/webadmin-jmap/pom.xml b/server/protocols/webadmin/webadmin-jmap/pom.xml index 7357c35e21..3669dd7760 100644 --- a/server/protocols/webadmin/webadmin-jmap/pom.xml +++ b/server/protocols/webadmin/webadmin-jmap/pom.xml @@ -66,6 +66,11 @@ <artifactId>james-server-data-memory</artifactId> <scope>test</scope> </dependency> + <dependency> + <groupId>${james.groupId}</groupId> + <artifactId>james-server-jmap-rfc-8621</artifactId> + <scope>test</scope> + </dependency> <dependency> <groupId>${james.groupId}</groupId> <artifactId>james-server-task-memory</artifactId> diff --git a/server/protocols/webadmin/webadmin-jmap/src/test/java/org/apache/james/webadmin/data/jmap/RecomputeAllFastViewProjectionItemsRequestToTaskTest.java b/server/protocols/webadmin/webadmin-jmap/src/test/java/org/apache/james/webadmin/data/jmap/RecomputeAllFastViewProjectionItemsRequestToTaskTest.java index 8519ef05ef..1397715ebe 100644 --- a/server/protocols/webadmin/webadmin-jmap/src/test/java/org/apache/james/webadmin/data/jmap/RecomputeAllFastViewProjectionItemsRequestToTaskTest.java +++ b/server/protocols/webadmin/webadmin-jmap/src/test/java/org/apache/james/webadmin/data/jmap/RecomputeAllFastViewProjectionItemsRequestToTaskTest.java @@ -32,8 +32,8 @@ import org.apache.james.core.Username; import org.apache.james.domainlist.api.DomainList; import org.apache.james.jmap.api.model.Preview; import org.apache.james.jmap.api.projections.MessageFastViewPrecomputedProperties; -import org.apache.james.jmap.draft.utils.JsoupHtmlTextExtractor; import org.apache.james.jmap.memory.projections.MemoryMessageFastViewProjection; +import org.apache.james.jmap.utils.JsoupHtmlTextExtractor; import org.apache.james.json.DTOConverter; import org.apache.james.mailbox.MailboxSession; import org.apache.james.mailbox.MessageManager; diff --git a/server/protocols/webadmin/webadmin-jmap/src/test/java/org/apache/james/webadmin/data/jmap/RecomputeUserFastViewProjectionItemsRequestToTaskTest.java b/server/protocols/webadmin/webadmin-jmap/src/test/java/org/apache/james/webadmin/data/jmap/RecomputeUserFastViewProjectionItemsRequestToTaskTest.java index e656b13b7f..baa92c90e2 100644 --- a/server/protocols/webadmin/webadmin-jmap/src/test/java/org/apache/james/webadmin/data/jmap/RecomputeUserFastViewProjectionItemsRequestToTaskTest.java +++ b/server/protocols/webadmin/webadmin-jmap/src/test/java/org/apache/james/webadmin/data/jmap/RecomputeUserFastViewProjectionItemsRequestToTaskTest.java @@ -33,8 +33,8 @@ import org.apache.james.core.Username; import org.apache.james.domainlist.api.DomainList; import org.apache.james.jmap.api.model.Preview; import org.apache.james.jmap.api.projections.MessageFastViewPrecomputedProperties; -import org.apache.james.jmap.draft.utils.JsoupHtmlTextExtractor; import org.apache.james.jmap.memory.projections.MemoryMessageFastViewProjection; +import org.apache.james.jmap.utils.JsoupHtmlTextExtractor; import org.apache.james.json.DTOConverter; import org.apache.james.mailbox.MailboxSession; import org.apache.james.mailbox.MessageManager; --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For additional commands, e-mail: notifications-h...@james.apache.org