Arsnael commented on code in PR #2630:
URL: https://github.com/apache/james-project/pull/2630#discussion_r1944084280
##########
server/testing/src/main/java/org/apache/james/utils/SMTPMessageSender.java:
##########
@@ -138,11 +138,12 @@ public SMTPMessageSender sendMessageWithHeaders(String
from, List<String> recipi
return this;
}
- public SMTPMessageSender sendMessageNoSender(String recipient) throws
IOException {
+ public SMTPMessageSender sendMessageNoSender(String from, String
recipient) throws IOException {
doHelo();
doSetSender("");
doAddRcpt(recipient);
- doData("subject: test\r\n" +
+ doData("FROM: " + from + "\r\n" +
Review Comment:
Added FROM header as we testing I believe here missing sender in the envelope
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org
