quantranhong1999 commented on code in PR #2634:
URL: https://github.com/apache/james-project/pull/2634#discussion_r1950176848
##########
docs/modules/servers/partials/configure/smtp.adoc:
##########
@@ -57,6 +57,11 @@ this case, if nobody is present, the value "localhost" will
be used.
with other proxies (e.g. traefik). If enabled, it is *required* to initiate
the connection
using HAProxy's proxy protocol.
+| proxyFirst
+| Wether proxy frames should be handled before SSL handshakes. This allows
setting either the loadbalancer in TCP mode
Review Comment:
```suggestion
| Whether proxy frames should be handled before SSL handshakes. This allows
setting either the loadbalancer in TCP mode
```
##########
docs/modules/servers/partials/configure/imap.adoc:
##########
@@ -118,6 +118,11 @@ Integer, defaults to 4096, must be positive, 0 means no
queue.
with other proxies (e.g. traefik). If enabled, it is *required* to initiate
the connection
using HAProxy's proxy protocol.
+| proxyFirst
+| Wether proxy frames should be handled before SSL handshakes. This allows
setting either the loadbalancer in TCP mode
Review Comment:
```suggestion
| Whether proxy frames should be handled before SSL handshakes. This allows
setting either the loadbalancer in TCP mode
```
##########
src/site/xdoc/server/config-imap4.xml:
##########
@@ -86,13 +86,18 @@
<dt><strong>maxQueueSize</strong></dt>
<dd>Upper bound to the IMAP throttler queue. Upon burst, requests that
cannot be queued are rejected and not executed.
Integer, defaults to 4096, must be positive, 0 means no queue.</dd>
- <dt><strong>handler.proxyRequired</strong></dt>
+ <dt><strong>proxyRequired</strong></dt>
<dd>
Enables proxy support for this service for incoming connections.
HAProxy's protocol
(https://www.haproxy.org/download/2.7/doc/proxy-protocol.txt) is
used and might be compatible
with other proxies (e.g. traefik). If enabled, it is *required* to
initiate the connection
using HAProxy's proxy protocol.
</dd>
+ <dt><strong>proxyFirst</strong></dt>
+ <dd>Wether proxy frames should be handled before SSL handshakes. This
allows setting either the loadbalancer in TCP mode
Review Comment:
```suggestion
<dd>Whether proxy frames should be handled before SSL handshakes.
This allows setting either the loadbalancer in TCP mode
```
##########
src/site/xdoc/server/config-smtp-lmtp.xml:
##########
@@ -81,6 +81,11 @@
with other proxies (e.g. traefik). If enabled, it is *required* to
initiate the connection
using HAProxy's proxy protocol.
</dd>
+ <dt><strong>proxyFirst</strong></dt>
+ <dd>Wether proxy frames should be handled before SSL handshakes. This
allows setting either the loadbalancer in TCP mode
Review Comment:
```suggestion
<dd>Whether proxy frames should be handled before SSL handshakes.
This allows setting either the loadbalancer in TCP mode
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org
