Arsnael commented on PR #2638: URL: https://github.com/apache/james-project/pull/2638#issuecomment-2655830599
Let me explain why the downgrade to 2.29.52 for the aws s3 sdk version in the fixup. Some serious breaking changes have been introduced since 2.30.0, with trailing checksums and overall some S3 default integrity protection changes explained here: https://github.com/aws/aws-sdk-java-v2/discussions/5802 This implies changes server side as well for object storages to keep being S3-compatible with the s3 sdk starting from that version. As said earlier, Minio I had an issue when deleting buckets, with missing md5-content header for the request. Similar to this issue opened on aws s3 sdk backlog: https://github.com/aws/aws-sdk-java-v2/issues/5848 By upgrading locally to latest minio version, the tests were green, means it got fixed. I can't say the same for scality though that we use mainly for tests. As commented above, they refuse the new header introduced in those new versions, and even if you disable the checksums in the client configuration and upgrade to latest image, I still have the issue with md5-content header missing for delete bucket requests. I guess initially @chibenwa you wanted to align netty versions with s3 sdk. But as I see, 2.30.16 is using netty 4.1.115 (https://github.com/aws/aws-sdk-java-v2/blob/2.30.16/pom.xml#L116) and 2.29.52 is as well (https://github.com/aws/aws-sdk-java-v2/blob/2.29.52/pom.xml#L116). It's from 2.30.17 that netty 4.1.118 seems being used (which is available on maven central now btw). But that introduces some massive breaking changes IMO that we should take the time to carefully consider and test. At least a refactoring to use minio on all our test instead of scality that seems determined to not make an effort for supporting this move. Also might need to upgrade production environments and test as well OVH s3 api if supported yet or not... Thus why I would suggest this in two steps. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For additional commands, e-mail: notifications-h...@james.apache.org
