Arsnael commented on code in PR #2642: URL: https://github.com/apache/james-project/pull/2642#discussion_r1959298176
########## docs/modules/servers/partials/configure/imap.adoc: ########## @@ -121,7 +121,7 @@ using HAProxy's proxy protocol. | proxyFirst | Whether proxy frames should be handled before SSL handshakes. This allows setting either the loadbalancer in TCP mode (so transparent for SSL then Proxy frames needs to be handled first) or set up SSL termination between proxy and server -(more suited for some cloud vendors). Defaults to true (TCP transparent). +(more suited for some cloud vendors). Defaults to false. Review Comment: It's false in the code. One or the other honestly. But faulty doc made me waste a morning trying to find the cause of why imap was not working anymore when deploying a new version with this change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For additional commands, e-mail: notifications-h...@james.apache.org
