vttranlina commented on code in PR #2646:
URL: https://github.com/apache/james-project/pull/2646#discussion_r1967032966


##########
server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/mail/MailboxFactory.scala:
##########
@@ -111,7 +111,7 @@ class MailboxFactory @Inject() (mailboxManager: 
MailboxManager,
         maySetSeen = MaySetSeen(rights.contains(Right.Seen)),
         maySetKeywords = MaySetKeywords(rights.contains(Right.Write)),
         mayCreateChild = MayCreateChild(false),
-        mayRename = MayRename(false),
+        mayRename = MayRename(rights.contains(Right.DeleteMailbox)),

Review Comment:
   https://jmap.io/spec-mail.html
   Note:
   ```
   mayRename: Boolean The user may rename the Mailbox or make it a child of 
another Mailbox. Corresponds to IMAP ACL x (although this covers both rename 
and delete permissions).
   ```
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org

Reply via email to