hungphan227 commented on PR #2669: URL: https://github.com/apache/james-project/pull/2669#issuecomment-2706001950
> > May need a test > > No, cf other draft PR on the refactoring. We concluded with @chibenwa that adding tests on all redis topologies was not really necessary and was just adding monstrous unnecessary complexity to the test suite. So just keeping one test for it (redis standalone) should be enough, we can accept for the rest I think at least do manual test to make sure. Ssl for different topology may require different redis client code and setup -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For additional commands, e-mail: notifications-h...@james.apache.org
