Arsnael commented on PR #2690: URL: https://github.com/apache/james-project/pull/2690#issuecomment-2765078347
Hmmm... For now yes only the health check is using the connection. The redis rate limiter is using a lib, `ratelimitj`, that takes the redis client and not the connection. I was more thinking of other custom works (like the redis event bus we have on tmail, but could be the case with other actors I believe) that could rely on the connection factory to have directly a connection depending of the redis topology. But maybe just returning the client makes sense, as it seems that's how it goes with some libs (like ratelimitj). But it means we need to manage the connections behind then. But as it's just a ping for the healthcheck I guess we could just have a pretty simple connection, as we do not do any operations on redis. Well I think I'm gonna look at your proposition on an other PR and we can compare and decide. Would that be ok for you @chibenwa ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For additional commands, e-mail: notifications-h...@james.apache.org
