jeantil opened a new pull request, #2700: URL: https://github.com/apache/james-project/pull/2700
It looks like James was using either outdated JDKIM APIs or at the very least JDKIM APIs that massively break the lib's encapsulation. This set a bad example for users of JDKIM looking for example usage, this PR proposes to change to a more idiomatic usage which has the added benefit of making hte DKIM related mailet's code much cleaner. The only downside I can think of is that it might have a performance impact, since the implementation of CRLFInputStream may not be optimal. It can be improved if it proves problematic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For additional commands, e-mail: notifications-h...@james.apache.org