quantranhong1999 commented on code in PR #2706: URL: https://github.com/apache/james-project/pull/2706#discussion_r2085882121
########## backends-common/redis/src/test/java/org/apache/james/backends/redis/RedisSentinelExtension.java: ########## @@ -109,7 +109,7 @@ private String createRedisSentinelURI() { sb.append("redis-sentinel://123@"); sb.append(this.stream().map(container -> container.getHost() + ":" + container.getMappedPort(SENTINEL_PORT)) .collect(Collectors.joining(","))); - sb.append("?sentinelMasterId=mymaster"); + sb.append("?sentinelMasterId=mymaster&timeout=3s"); Review Comment: I think we can keep removing reactor timeout. As we have healthcheck timeout safeguard already https://github.com/apache/james-project/blob/11646b05bbc539492fd3715230c22388174a30ad/server/container/guice/common/src/main/java/org/apache/james/PeriodicalHealthChecks.java#L59. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For additional commands, e-mail: notifications-h...@james.apache.org