chibenwa commented on code in PR #2737: URL: https://github.com/apache/james-project/pull/2737#discussion_r2126160025
########## mailbox/opensearch/src/main/java/org/apache/james/mailbox/opensearch/query/DefaultCriterionConverter.java: ########## @@ -85,14 +85,14 @@ public DefaultCriterionConverter() { registerHeaderOperatorConverters(); } - private String evaluateFuzzinessValue(boolean textFuzzinessSearchEnable) { + protected String evaluateFuzzinessValue(boolean textFuzzinessSearchEnable) { Review Comment: Limiting the code duplication is IMO desirable. extend DefaultCriterionConverter in tmail is BTW not incompatible with interface in tmail BTW it would ease injects... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For additional commands, e-mail: notifications-h...@james.apache.org