jeantil commented on code in PR #2785:
URL: https://github.com/apache/james-project/pull/2785#discussion_r2274822952


##########
Jenkinsfile:
##########
@@ -96,7 +96,7 @@ pipeline {
         stage('Stable Tests') {
             steps {
                 echo 'Running tests'
-                sh 'mvn -B -e -fae test ${MVN_SHOW_TIMESTAMPS} -P ci-test 
${MVN_LOCAL_REPO_OPT} -Dassembly.skipAssembly=true 
jacoco:report-aggregate@jacoco-report'
+                sh 'mvn -B -e -fae clean test ${MVN_SHOW_TIMESTAMPS} -P 
ci-test ${MVN_LOCAL_REPO_OPT} -Dassembly.skipAssembly=true 
jacoco:report-aggregate@jacoco-report'

Review Comment:
   clean is required for storing results in the build cache 
   the remote build cache will ensure we don't spend to much rebuilding already 
built stuff
   
   anyway build time is negligible compared to test runtime so event with 
suboptimal caching we should benefit



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org

Reply via email to