quantranhong1999 commented on code in PR #2842:
URL: https://github.com/apache/james-project/pull/2842#discussion_r2476940588


##########
server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/EmailSetMethodContract.scala:
##########
@@ -6495,23 +6495,20 @@ trait EmailSetMethodContract {
   def emailSetDestroyShouldDestroyEmailWhenMovedIntoAnotherMailbox(server: 
GuiceJamesServer): Unit = {
     val mailboxProbe = server.getProbe(classOf[MailboxProbeImpl])
 
-    val andreMailbox: String = "andrecustom"
-    val andrePath = MailboxPath.forUser(ANDRE, andreMailbox)
-    val bobPath = MailboxPath.inbox(BOB)
-    mailboxProbe.createMailbox(andrePath)
-    val mailboxId: MailboxId = mailboxProbe.createMailbox(bobPath)
+    val mailbox: String = "custom"
+    val anotherMailbox: String = "anotherCustom"
+    mailboxProbe.createMailbox(MailboxPath.forUser(BOB, mailbox))
+    val anotherMailboxId = mailboxProbe.createMailbox(MailboxPath.forUser(BOB, 
anotherMailbox))

Review Comment:
   
   At first, the `emailSetDestroyShouldDestroyEmailWhenMovedIntoAnotherMailbox` 
test failed because Bob did not have the Read right on the team mailbox, 
therefore `MailboxNotFoundException`. Indeed, the test failed on my local. 
Adding the read right should fix the test (at least on my local, makes sense 
though). However, somehow the tests still failed on CI with the same error, 
just like there was no read right added. I was not sure if it could be a build 
cache issue.
   
   I am tired of fixing thing that is supposed to pass on the CI, therefore I 
refactored the
   `emailSetDestroyShouldDestroyEmailWhenMovedIntoAnotherMailbox` test to not 
use the share mailbox anymore, also hope it would force the CI the rebuild the 
new test resource for this test.
   
   However, even after refactoring (no more `andrecustom` mailbox used in the 
test), the CI still failed with the same error in the latest build: 
https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-2842/9/testReport/org.apache.james.jmap.rfc8621.memory/MemoryEmailSetMethodTest/emailSetDestroyShouldDestroyEmailWhenMovedIntoAnotherMailbox_GuiceJamesServer_/
 saying `#private:[email protected]:andrecustom can not be found`.
   
   Note that I tried opening another PR 
https://github.com/apache/james-project/pull/2843, but it did not help.
   
   It seems the outdated build cache (oudated test jar?) used for this test and 
not refreshed correctly... cc @jeantil do you have any idea?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to