felixauringer commented on code in PR #2773:
URL: https://github.com/apache/james-project/pull/2773#discussion_r2580601752
##########
mpt/impl/managesieve/core/src/main/resources/org/apache/james/managesieve/scripts/capability.test:
##########
@@ -39,7 +39,7 @@ S: OK
C: AUTHENTICATE "PLAIN"
S: \+ ""
-C: user password
+C: user password
Review Comment:
I would argue that the line before the one you referenced is also important
here: `C: {21}`
The clients announces the exact length of its message. This syntax is
defined in the managesieve standard but currently not implemented in James. I
do not know whether there are any clients using it.
The exact line `C: user password` appears multiple times in the managesieve
MPL tests that were there before my contribution.
I think in the MPL tests only use plain authentication with continuation,
use spaces instead of NUL and do not quote the client message during
continuation.
The Java Tests I wrote usually use NUL (including the leading NUL) and
encode it with base64. However, there is also one test for accepting it without
the leading NUL and one that accepts the credentials with one space between
username and password (not base64 encoded). There are no Java tests that do
test those variants also with continuation.
I am not exactly sure what additional tests you would like to have.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
