Arsnael commented on PR #2883: URL: https://github.com/apache/james-project/pull/2883#issuecomment-3639716996
The charset tests have been fixed. We had to disable the remote cache previously because it was failing with it. Without the cache it was green. The tests with `\r\n` and `\n` is a difference issue with line separators between CRLF (which tends to be what Windows does) and LF (which tends to be what Linux does). I could be mistaken but James codebase was likely initially created under windows (CRLF) , so some of those files like thos eemls are in CRLF. But you checked out under Linux and git probably did some auto conversion to LF, thus the issues in your tests. I can't remember exactly what is the best way to tell git on what to do here, maybe @chibenwa remembers better than me. But it's a bit of a pain indeed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
