chibenwa commented on code in PR #2886:
URL: https://github.com/apache/james-project/pull/2886#discussion_r2630460970


##########
mailbox/api/src/main/java/org/apache/james/mailbox/events/MailboxEvents.java:
##########
@@ -537,7 +537,8 @@ public final int hashCode() {
     }
 
     record MessageContentDeletionEvent(EventId eventId, Username username, 
MailboxId mailboxId, MessageId messageId, long size,
-                                       Instant internalDate, boolean 
hasAttachments, String headerBlobId, String bodyBlobId) implements Event {
+                                       Instant internalDate, boolean 
hasAttachments, Optional<String> headerBlobId, Optional<String> headerContent,

Review Comment:
   +1 for making headerContent optional
   
   This allows for per-implementation variability



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to