Arsnael commented on code in PR #2894:
URL: https://github.com/apache/james-project/pull/2894#discussion_r2660190650


##########
src/adr/0076-deleted-message-vault-single-bucket.md:
##########
@@ -0,0 +1,40 @@
+# 76. Deleted Message Vault: single bucket usage

Review Comment:
   @mbaechler  Not against it, but I agree with @chibenwa on the fact that then 
it should be discussed with the community (ML) and should be treated in an 
other PR when we reach a  proper consensus
   
   If we start having adrs all around the place though I'm afraid it might be 
confusing. What about subfolders instead? 
   
   ```
   src/
     - adr/
       + core/
       + extensions/
   [...]
   ```
   
   I think it's clear, it's still in one place, subfolders allow easily for 
someone to just look at the core James ADRs if he just wishes to understand 
James basic core concepts, and also still easy to find extensions ADRs if one 
needs them? It would be confusing IMO to go look into the module of those 
extensions to find potential ADRs related to it.
   
   ? Will start a ML anyways on this today :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to