jeantil commented on code in PR #2895:
URL: https://github.com/apache/james-project/pull/2895#discussion_r2660406608
##########
server/apps/spring-app/src/main/resources/log4j2.xml:
##########
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<Configuration status="INFO" monitorInterval="30">
<Properties>
- <Property name="logDir">${sys:app.home}/log</Property>
+ <Property name="logDir">${sys:app.home:-..}/log</Property>
Review Comment:
yes, this is consistent with the [install
instructions](https://james.apache.org/server/install.html)
> Go to the bin subdirectory of the installation directory and run $ ./james
start.
james is generated by the app assembler plugin and doesn't define app.home
There is also a run.sh script in the same bin directory but this one defines
app.home so the fallback will not be used in that case.
the install instructions only make sense for the spring variant too as the
other do not use the appassembler-maven-plugin so the install instructions
wouldn't work ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
