Arsnael commented on code in PR #2902:
URL: https://github.com/apache/james-project/pull/2902#discussion_r2680733239
##########
mailbox/plugin/deleted-messages-vault/src/test/java/org/apache/james/vault/blob/BlobStoreDeletedMessageVaultTest.java:
##########
@@ -185,7 +185,7 @@ void
deleteExpiredMessagesTaskShouldPublishRetentionTimerMetrics() throws Except
getVault().deleteExpiredMessagesTask().run();
assertThat(metricFactory.executionTimesFor(DELETE_EXPIRED_MESSAGES_METRIC_NAME))
- .hasSize(1);
+ .hasSize(2);
Review Comment:
Because I wrap the new expiration mechanism in the same metric name, so
being called twice. Is that ok? Knowing that when we remove the deprecated
version it will be back to one? Or better finding a better way here?
##########
server/protocols/webadmin-integration-test/webadmin-integration-test-common/src/main/java/org/apache/james/webadmin/integration/vault/DeletedMessageVaultIntegrationTest.java:
##########
@@ -770,6 +771,7 @@ void vaultDeleteShouldNotAppendMessageToTheUserMailbox() {
.hasSize(0);
}
+ @Disabled("JAMES-4156")
Review Comment:
As said in a comment above, I don't even understand if this case is supposed
to be valid or not, even more with the new design.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
