chibenwa commented on PR #2894: URL: https://github.com/apache/james-project/pull/2894#issuecomment-3754406349
Hello @jeantil > I didn't completely agree with Benoit's proposed implementation direction and reminded him of an alternative which already exists in the code base and encodes the virtual path/virtual folder in the blob id instead of changing the bucketname While conceptually better this direction indeed have broad impact; I must confess it do not seem like a reachable goal to consensually achieve a full refactoring of S3BlobStoreDAO to operate off a single bucket. Marginal gains compared to just "rewritting the Deleted Message Vault" to use a single bucket do not seem in favor of the full-s3-refactoring idea. > the virtual path/virtual folder in the blob id instead of changing the bucketname This is somewhat what https://github.com/apache/james-project/pull/2902 achieves, and is in line with the current ADR. BTW this is the direction we (linagorians) chose to move on with for Twake Mail. > you will move the development to your closed source extension, which is your right but also a bit sad. I think there's a misunderstanding here indeed. As employee I am accountable for time spent on the project and that it results in fixing the problem my employer faces. If to reach this end this means moving forward on a separate, company owned repo then be it (Twake mail is not closed source, but AGPL v3 and owned by LINAGORA). But indeed this is a problem others in the James community will face and indeed maintenance costs will be lower with this code change within James. And carrying the two approaches are not mutually exclusive, and could even converge later depending on feedback ! I propose to bring this to the mailing list thread, and to a vote: - Address the use of several bucket of the Deleted Message Vault ( this ADR + #2902 ) - Do not attempt to merge everything into a single bucket at the S3 level. We won't attempt to solve the issue globally at the S3 level, but focus on the scope where it is currently problematic, just within the scope of the "deleted message vault" which is where it is problematic for distributed + PG users. Cheers, Benoit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
