chibenwa commented on code in PR #2913:
URL: https://github.com/apache/james-project/pull/2913#discussion_r2694883655
##########
server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/VacationMailet.java:
##########
@@ -100,18 +119,16 @@ public void service(Mail mail) {
@Override
public void init() throws MessagingException {
useUserAsMailFrom = MailetUtil.getInitParameter(getMailetConfig(),
"useUserAsMailFrom").orElse(false);
+ replyMode = Optional.ofNullable(getInitParameter("replyMode"))
+ .map(value -> ReplyMode.parse(value).orElseThrow(() -> new
IllegalArgumentException("Unsupported ReplyMode " + value)))
+ .orElse(ReplyMode.REPLY_TO_HEADER);
Review Comment:
This behaviour is **wrong** and by preserving the same broken behaviour by
default we ship incorrect-hard-to-configure-to-get-correct software.
Most people will miss-configure this and would have broken behaviour on
prod.
I'd rather fix-by-default and offer a way to fallback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
