jeantil commented on code in PR #2902:
URL: https://github.com/apache/james-project/pull/2902#discussion_r2703732808
##########
mailbox/plugin/deleted-messages-vault/src/main/java/org/apache/james/vault/VaultConfiguration.java:
##########
@@ -31,32 +31,38 @@
import com.google.common.base.Preconditions;
public class VaultConfiguration {
+ public static final String DEFAULT_SINGLE_BUCKET_NAME =
"james-deleted-message-vault";
Review Comment:
>Is it still unclear on that point @jeantil ?
no that's perfectly clear
>The goal in the end would be to put all blobs under one S3 bucket yes.
This can be achieved today using the `prefix` or `namespace` configuration
of blob.properties (sorry I don't exactly remember which I had to use, this is
not so well documented) but is not really my point.
I think the constant should not contain the word `SINGLE` as this only makes
sense in the current refactoring context. if you were building this feature
from scratch today based on the new design you would not call it single.
As I understand it this is the `Blobstore` bucket name (so a logical bucket
name) under which all the blobs of the feature implemented by the plugin will
be written. The actual S3 bucket name in which this logical bucket is stored
can be different based on the `blob.properties` configuration ( prefix and
namespace will affect the actual storage namespace)
Hence my proposal to call it `DEFAULT_VAULT_BUCKET` (by no means definitive)
> I don't want this to mess up with mailbox GC. I'd rather have a separate
blob store bucket if given the choice.
I'm not sure how my proposed name change or how using the prefix/namespace
features of blob.properties changes would afffect the mailbox GC ... I propose
we discuss this with actual examples on the ADR. This goes beyond my intention
for the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
