felixauringer commented on PR #2915: URL: https://github.com/apache/james-project/pull/2915#issuecomment-3768835718
When using introspection, there are currently two places with aud checks: - [`verifySignatureAndExtractClaim`](https://github.com/chibenwa/james-project/blob/9de14ee9afcc86aa455a1bd1352da696c012f5d3/server/protocols/jwt/src/main/java/org/apache/james/jwt/OidcJwtTokenVerifier.java#L79) - [`verifyWithIntrospection`](https://github.com/chibenwa/james-project/blob/9de14ee9afcc86aa455a1bd1352da696c012f5d3/server/protocols/jwt/src/main/java/org/apache/james/jwt/OidcJwtTokenVerifier.java#L94) which also calls `verifySignatureAndExtractClaim` I am not sure whether the second is still needed. As far as I see it, the signature verification - which now also includes the aud check - is done in every code path anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
