quantranhong1999 commented on code in PR #2962:
URL: https://github.com/apache/james-project/pull/2962#discussion_r2888701622
##########
server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/EmailQueryMethodContract.scala:
##########
@@ -5018,21 +5027,20 @@ trait EmailQueryMethodContract {
@Test
def combiningSortPositionAndLimitShouldYieldExpectedResult(server:
GuiceJamesServer): Unit = {
val mailboxId =
server.getProbe(classOf[MailboxProbeImpl]).createMailbox(MailboxPath.inbox(BOB))
- val message: Message = buildTestMessage
val messageId1: MessageId = server.getProbe(classOf[MailboxProbeImpl])
.appendMessage(BOB.asString, MailboxPath.inbox(BOB),
AppendCommand.builder()
.withInternalDate(Date.from(ZonedDateTime.now().minusDays(2).toInstant))
Review Comment:
internalDate there is not really the sentAt date. Likely, we should change
it to make it less confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
