chibenwa commented on code in PR #2973:
URL: https://github.com/apache/james-project/pull/2973#discussion_r2925526541
##########
server/data/data-api/src/main/java/org/apache/james/user/api/UsersRepository.java:
##########
@@ -188,6 +188,13 @@ default Mono<Void> assertValidReactive(Username username) {
}
default Publisher<Username> listUsersOfADomainReactive(Domain domain) {
+ try {
+ if (!supportVirtualHosting()) {
+ return Flux.error(new
IllegalStateException("listUsersOfADomainReactive is not supported when virtual
hosting is disabled"));
Review Comment:
> just to be clear : my comment was not a request for change I don't think I
ever used james without virtual hosting so I really don't know :D
Yes but the legitimate question made me realize we could do a better job
here.
> but if my comment made you rethink the implem, its fine too :D
:+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
