chibenwa commented on code in PR #3041:
URL: https://github.com/apache/james-project/pull/3041#discussion_r3266441743
##########
server/protocols/webadmin/webadmin-mailbox/src/main/java/org/apache/james/webadmin/service/MailboxesRestoreTaskDTO.java:
##########
@@ -73,7 +73,7 @@ public static TaskDTOModule<MailboxesRestoreTask,
MailboxesRestoreTaskDTO> modul
}
public MailboxesRestoreTask fromDTO(RestoreService service, BlobId.Factory
blobIdFactory) {
- return new MailboxesRestoreTask(service, Username.of(username),
blobIdFactory.of(blobId), force);
+ return new MailboxesRestoreTask(service, Username.of(username),
blobIdFactory.parse(blobId), force != null && force);
Review Comment:
Why is force nullable in the first place ? Have it as Optional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
