quantranhong1999 commented on code in PR #3080:
URL: https://github.com/apache/james-project/pull/3080#discussion_r3518627959
##########
server/apps/memory-app/src/main/java/org/apache/james/MemoryJamesConfiguration.java:
##########
@@ -89,6 +92,11 @@ public Builder enableJMAP() {
return this;
}
+ public Builder enableJMAPOidc() {
+ this.jmapOidcEnabled = Optional.of(true);
Review Comment:
> If the multibinder for auth strategies do not declare it
Guice loader, actually.
> then it wont be pulled, along with its dependencies, don't I get it
correctly ?
Mostly. But there is a caveat here: the `OidcBackchannelLogoutRoutes` may be
loaded, as it is not a dependency of the `OidcAuthenticationStrategy`, which is
not what we want.
So I think that configuration gate is still valid. BTW, we have done this
for TMail already; nothing "new" was introduced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
