prosgarz35 commented on PR #3194:
URL: https://github.com/apache/james-project/pull/3194#issuecomment-5811346918

   > ```
   >         <dependency>
   >             <?SORTPOM IGNORE?>
   >             <groupId>io.netty</groupId>
   >             <artifactId>netty-transport</artifactId>
   >             <?SORTPOM RESUME?>
   >         </dependency>
   > ```
   > 
   > Remaining point for me is the netty version allignement. I recommend 
building distributed app, pg app and manually verify that netty jars stays 
alligned (all same version).
   
       We built and manually verified the packaged Netty jars across the server 
applications (`mvn package -DskipTests`), including `postgres-app`, 
`distributed-app`, `jpa-app`, `jpa-smtp-app`, `memory-app`, and `spring-app`:
   
       In all assemblies (`.lib` directories and packaged zip/tar archives), 
every single `io.netty` jar is strictly unified under version 
**`4.1.135.Final`**:
       - `netty-buffer-4.1.135.Final.jar`
       - `netty-codec-4.1.135.Final.jar`
       - `netty-codec-dns-4.1.135.Final.jar`
       - `netty-codec-haproxy-4.1.135.Final.jar`
       - `netty-codec-http-4.1.135.Final.jar`
       - `netty-codec-http2-4.1.135.Final.jar`
       - `netty-codec-socks-4.1.135.Final.jar`
       - `netty-common-4.1.135.Final.jar`
       - `netty-handler-4.1.135.Final.jar`
       - `netty-handler-proxy-4.1.135.Final.jar`
       - `netty-resolver-4.1.135.Final.jar`
       - `netty-resolver-dns-4.1.135.Final.jar`
       - `netty-resolver-dns-classes-macos-4.1.135.Final.jar`
       - `netty-resolver-dns-native-macos-4.1.135.Final-osx-x86_64.jar`
       - `netty-transport-4.1.135.Final.jar`
       - `netty-transport-classes-epoll-4.1.135.Final.jar`
       - `netty-transport-native-epoll-4.1.135.Final.jar`
       - `netty-transport-native-epoll-4.1.135.Final-linux-x86_64.jar`
       - `netty-transport-native-unix-common-4.1.135.Final.jar`
   
       Importing `io.netty:netty-bom:${netty.version}` into root 
`<dependencyManagement>` successfully prevents any Netty version divergence 
across the entire project and all packaging targets.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to