chibenwa commented on code in PR #3213:
URL: https://github.com/apache/james-project/pull/3213#discussion_r4133509552
##########
server/mailrepository/mailrepository-blob/src/main/scala/org/apache/james/mailrepository/blob/BlobMailRepository.scala:
##########
@@ -169,35 +180,96 @@ class BlobMailRepository(val mailMetaDataBlobStore:
BlobStore,
.map(mailPartsId => mailPartsId.toMailKey)
.block()
+ oldMimeId.foreach(mimeId =>
+ SMono.fromPublisher(mimeMessageStore.delete(mimeId))
+ .retryWhen(Retry.backoff(2, Duration.ofMillis(50)))
+ .doOnError(e => LOGGER.warn("Failed to delete superseded MIME blobs {}
and {} for mail {} in {}",
+ mimeId.getHeaderBlobId.asString(), mimeId.getBodyBlobId.asString(),
mc.getName, url.asString(), e))
+ .onErrorResume(_ => SMono.empty)
+ .block()
+ )
Review Comment:
Cut it in small parts:
- 1 PR for contract changes, @Disabled for BlobMailRepository
- 1 PR for BlobMailRepositoryV2 alone
- 1 PR for deprecation and upgrade procedure.
Smaller chunks makes things generally more manageable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
