prosgarz35 commented on code in PR #3223:
URL: https://github.com/apache/james-project/pull/3223#discussion_r4153923643
##########
server/protocols/jwt/src/main/java/org/apache/james/jwt/PublicKeyReader.java:
##########
@@ -44,7 +45,11 @@ private Optional<PublicKey> publicKeyFrom(PEMParser reader) {
if (readPEM instanceof SubjectPublicKeyInfo) {
return Optional.of(new
JcaPEMKeyConverter().getPublicKey((SubjectPublicKeyInfo) readPEM));
}
- LOGGER.warn("Key is not an instance of SubjectPublicKeyInfo but of
{}", readPEM);
+ if (readPEM instanceof X509CertificateHolder) {
Review Comment:
> On the principle, yes.
>
> In practice certificate means we likely shall check `notBefore/notAfter`...
i made it check but only WARN not REJECT cuz... you sure dont wanna your
server going down when you just forget this certificate...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
