HesandaLiyanage commented on PR #3193: URL: https://github.com/apache/james-project/pull/3193#issuecomment-6053660335
> Kid woke up I did not go to the heart of it (BlobCompactionAlgoritm) We are clearly improving in terms of quality but this change set is way to big to get though as is. And 100+ comments is too much to keep tracking efficiently. I would advocate to split it in subparts that each make sense. Can you please propose on [[email protected]](mailto:[email protected]) mailing list or on the JIRA ticket a list of small/smaller PRs ? We can keep this PR open as a draft / a reference. I'd have a reference branch `JAMES-4231` on the repo to handle this as a eature branch. Best regards, Benoit Hey @chibenwa , Yes agree, 8k+ lines in one PR is way too much to follow. Im switching #3193 to draft so it stays around as the reference implementation. im going to split it into 8 smaller sub PRs, most under 300 lines, with the core engine in its own module. i'm putting the breakdown on server-dev and the JIRA ticket now so you can check it before i start. once the JAMES-4231 feature branch exists on the repo i'll open the sub PRs against it in order. Thanks for the guidance !!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
