It modernizes SoftLayer CCI support by re-using the same API calls used by 
SoftLayer Python client.
The implementation should be not more easily maintainable and robust.
You can merge this Pull Request by running:

  git pull https://github.com/andreaturli/jclouds refactor/softlayer

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds/pull/296

-- Commit Summary --

  * [JCLOUDS-474] refactor SoftLayer support

-- File Changes --

    M providers/softlayer/pom.xml (15)
    M providers/softlayer/src/main/java/org/jclouds/softlayer/SoftLayerApi.java 
(28)
    M 
providers/softlayer/src/main/java/org/jclouds/softlayer/SoftLayerApiMetadata.java
 (30)
    M 
providers/softlayer/src/main/java/org/jclouds/softlayer/SoftLayerProviderMetadata.java
 (32)
    D 
providers/softlayer/src/main/java/org/jclouds/softlayer/binders/ProductOrderToJson.java
 (133)
    A 
providers/softlayer/src/main/java/org/jclouds/softlayer/binders/VirtualGuestToJson.java
 (146)
    M 
providers/softlayer/src/main/java/org/jclouds/softlayer/compute/config/SoftLayerComputeServiceContextModule.java
 (85)
    M 
providers/softlayer/src/main/java/org/jclouds/softlayer/compute/functions/DatacenterToLocation.java
 (10)
    A 
providers/softlayer/src/main/java/org/jclouds/softlayer/compute/functions/OperatingSystemToImage.java
 (145)
    D 
providers/softlayer/src/main/java/org/jclouds/softlayer/compute/functions/ProductItemToImage.java
 (187)
    D 
providers/softlayer/src/main/java/org/jclouds/softlayer/compute/functions/ProductItems.java
 (90)
    D 
providers/softlayer/src/main/java/org/jclouds/softlayer/compute/functions/ProductItemsToHardware.java
 (124)
    A 
providers/softlayer/src/main/java/org/jclouds/softlayer/compute/functions/VirtualGuestToHardware.java
 (73)
    A 
providers/softlayer/src/main/java/org/jclouds/softlayer/compute/functions/VirtualGuestToImage.java
 (154)
    M 
providers/softlayer/src/main/java/org/jclouds/softlayer/compute/functions/VirtualGuestToNodeMetadata.java
 (84)
    M 
providers/softlayer/src/main/java/org/jclouds/softlayer/compute/options/SoftLayerTemplateOptions.java
 (32)
    M 
providers/softlayer/src/main/java/org/jclouds/softlayer/compute/strategy/SoftLayerComputeServiceAdapter.java
 (264)
    M 
providers/softlayer/src/main/java/org/jclouds/softlayer/config/SoftLayerParserModule.java
 (8)
    R 
providers/softlayer/src/main/java/org/jclouds/softlayer/config/SoftLayerRestClientModule.java
 (10)
    M 
providers/softlayer/src/main/java/org/jclouds/softlayer/domain/Address.java 
(179)
    A 
providers/softlayer/src/main/java/org/jclouds/softlayer/domain/ContainerVirtualGuestConfiguration.java
 (286)
    A 
providers/softlayer/src/main/java/org/jclouds/softlayer/domain/ContainerVirtualGuestConfigurationOption.java
 (117)
    M 
providers/softlayer/src/main/java/org/jclouds/softlayer/domain/Datacenter.java 
(27)
    M 
providers/softlayer/src/main/java/org/jclouds/softlayer/domain/OperatingSystem.java
 (83)
    M 
providers/softlayer/src/main/java/org/jclouds/softlayer/domain/Password.java (2)
    M 
providers/softlayer/src/main/java/org/jclouds/softlayer/domain/PowerState.java 
(2)
    M 
providers/softlayer/src/main/java/org/jclouds/softlayer/domain/ProductItem.java 
(206)
    D 
providers/softlayer/src/main/java/org/jclouds/softlayer/domain/ProductItemCategory.java
 (154)
    M 
providers/softlayer/src/main/java/org/jclouds/softlayer/domain/ProductItemPrice.java
 (204)
    D 
providers/softlayer/src/main/java/org/jclouds/softlayer/domain/ProductOrder.java
 (224)
    D 
providers/softlayer/src/main/java/org/jclouds/softlayer/domain/ProductOrderReceipt.java
 (136)
    D 
providers/softlayer/src/main/java/org/jclouds/softlayer/domain/ProductPackage.java
 (208)
    A 
providers/softlayer/src/main/java/org/jclouds/softlayer/domain/SoftwareDescription.java
 (308)
    A 
providers/softlayer/src/main/java/org/jclouds/softlayer/domain/SoftwareLicense.java
 (142)
    A 
providers/softlayer/src/main/java/org/jclouds/softlayer/domain/VirtualDiskImage.java
 (233)
    M 
providers/softlayer/src/main/java/org/jclouds/softlayer/domain/VirtualGuest.java
 (157)
    A 
providers/softlayer/src/main/java/org/jclouds/softlayer/domain/VirtualGuestBlockDevice.java
 (252)
    D 
providers/softlayer/src/main/java/org/jclouds/softlayer/features/AccountApi.java
 (59)
    M 
providers/softlayer/src/main/java/org/jclouds/softlayer/features/DatacenterApi.java
 (28)
    R 
providers/softlayer/src/main/java/org/jclouds/softlayer/features/SoftwareDescriptionApi.java
 (40)
    M 
providers/softlayer/src/main/java/org/jclouds/softlayer/features/VirtualGuestApi.java
 (143)
    M 
providers/softlayer/src/main/java/org/jclouds/softlayer/handlers/SoftLayerErrorHandler.java
 (5)
    D 
providers/softlayer/src/main/java/org/jclouds/softlayer/predicates/ProductItemPredicates.java
 (154)
    D 
providers/softlayer/src/main/java/org/jclouds/softlayer/predicates/ProductPackagePredicates.java
 (41)
    M 
providers/softlayer/src/main/java/org/jclouds/softlayer/reference/SoftLayerConstants.java
 (30)
    D 
providers/softlayer/src/test/java/org/jclouds/softlayer/SoftLayerApiTest.java 
(55)
    M 
providers/softlayer/src/test/java/org/jclouds/softlayer/SoftLayerProviderTest.java
 (8)
    D 
providers/softlayer/src/test/java/org/jclouds/softlayer/binders/ProductOrderToJsonTest.java
 (94)
    M 
providers/softlayer/src/test/java/org/jclouds/softlayer/compute/SoftLayerComputeServiceAdapterLiveTest.java
 (28)
    M 
providers/softlayer/src/test/java/org/jclouds/softlayer/compute/SoftLayerComputeServiceLiveTest.java
 (19)
    A 
providers/softlayer/src/test/java/org/jclouds/softlayer/compute/SoftLayerExperimentIntegrationTest.java
 (102)
    R 
providers/softlayer/src/test/java/org/jclouds/softlayer/compute/SoftLayerTemplateBuilderIntegrationTest.java
 (66)
    M 
providers/softlayer/src/test/java/org/jclouds/softlayer/compute/functions/DatacenterToLocationTest.java
 (19)
    D 
providers/softlayer/src/test/java/org/jclouds/softlayer/compute/functions/ProductItemToImageTest.java
 (264)
    D 
providers/softlayer/src/test/java/org/jclouds/softlayer/compute/functions/ProductItemsTest.java
 (143)
    D 
providers/softlayer/src/test/java/org/jclouds/softlayer/compute/functions/ProductItemsToHardwareTest.java
 (157)
    M 
providers/softlayer/src/test/java/org/jclouds/softlayer/compute/functions/VirtualGuestToNodeMetadataTest.java
 (31)
    D 
providers/softlayer/src/test/java/org/jclouds/softlayer/features/AccountApiTest.java
 (55)
    R 
providers/softlayer/src/test/java/org/jclouds/softlayer/features/BaseSoftLayerApiExpectTest.java
 (17)
    M 
providers/softlayer/src/test/java/org/jclouds/softlayer/features/BaseSoftLayerApiLiveTest.java
 (3)
    A 
providers/softlayer/src/test/java/org/jclouds/softlayer/features/DatacenterApiExpectTest.java
 (95)
    M 
providers/softlayer/src/test/java/org/jclouds/softlayer/features/DatacenterApiLiveTest.java
 (49)
    D 
providers/softlayer/src/test/java/org/jclouds/softlayer/features/DatacenterApiTest.java
 (85)
    D 
providers/softlayer/src/test/java/org/jclouds/softlayer/features/ProductPackageApiLiveTest.java
 (218)
    D 
providers/softlayer/src/test/java/org/jclouds/softlayer/features/ProductPackageApiTest.java
 (55)
    A 
providers/softlayer/src/test/java/org/jclouds/softlayer/features/SoftwareDescriptionApiExpectTest.java
 (64)
    R 
providers/softlayer/src/test/java/org/jclouds/softlayer/features/SoftwareDescriptionApiLiveTest.java
 (33)
    M 
providers/softlayer/src/test/java/org/jclouds/softlayer/features/VirtualGuestApiExpectTest.java
 (135)
    M 
providers/softlayer/src/test/java/org/jclouds/softlayer/features/VirtualGuestApiLiveTest.java
 (212)
    D 
providers/softlayer/src/test/java/org/jclouds/softlayer/features/VirtualGuestApiTest.java
 (175)
    R 
providers/softlayer/src/test/java/org/jclouds/softlayer/internal/BaseSoftLayerParseTest.java
 (23)
    R 
providers/softlayer/src/test/java/org/jclouds/softlayer/parse/CreateVirtualGuestResponseTest.java
 (56)
    A 
providers/softlayer/src/test/java/org/jclouds/softlayer/parse/GetAllObjectsResponseTest.java
 (64)
    A 
providers/softlayer/src/test/java/org/jclouds/softlayer/parse/GetDatacenterResponseTest.java
 (67)
    A 
providers/softlayer/src/test/java/org/jclouds/softlayer/parse/GetVirtualGuestResponseTest.java
 (69)
    A 
providers/softlayer/src/test/java/org/jclouds/softlayer/parse/ListDatacentersResponseTest.java
 (118)
    A 
providers/softlayer/src/test/java/org/jclouds/softlayer/parse/ListVirtualGuestsResponseTest.java
 (72)
    D 
providers/softlayer/src/test/java/org/jclouds/softlayer/parse/ParseProductOrderTest.java
 (105)
    D 
providers/softlayer/src/test/java/org/jclouds/softlayer/parse/ParseVirtualGuestHaltedTest.java
 (73)
    D 
providers/softlayer/src/test/java/org/jclouds/softlayer/parse/ParseVirtualGuestPausedTest.java
 (73)
    D 
providers/softlayer/src/test/java/org/jclouds/softlayer/parse/ParseVirtualGuestRunningTest.java
 (73)
    D 
providers/softlayer/src/test/java/org/jclouds/softlayer/parse/ParseVirtualGuestWithNoPasswordTest.java
 (69)
    D 
providers/softlayer/src/test/java/org/jclouds/softlayer/predicates/ProductItemPredicatesTest.java
 (101)
    D 
providers/softlayer/src/test/java/org/jclouds/softlayer/predicates/ProductPackagePredicatesTest.java
 (44)
    A providers/softlayer/src/test/resources/datacenter_get.json (30)
    A providers/softlayer/src/test/resources/datacenter_list.json (72)
    D providers/softlayer/src/test/resources/log4j.xml (151)
    A providers/softlayer/src/test/resources/logback.xml (34)
    D providers/softlayer/src/test/resources/product_order_template.json (1337)
    A providers/softlayer/src/test/resources/software_description_list.json (21)
    D providers/softlayer/src/test/resources/virtual_guest_bad_halted.json (4)
    A providers/softlayer/src/test/resources/virtual_guest_create.json (1)
    A providers/softlayer/src/test/resources/virtual_guest_create_response.json 
(19)
    A providers/softlayer/src/test/resources/virtual_guest_get.json (22)
    D providers/softlayer/src/test/resources/virtual_guest_good_halted.json 
(117)
    A providers/softlayer/src/test/resources/virtual_guest_list.json (24)
    D providers/softlayer/src/test/resources/virtual_guest_no_password.json (74)
    D providers/softlayer/src/test/resources/virtual_guest_paused.json (117)
    D providers/softlayer/src/test/resources/virtual_guest_running.json (117)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/296.patch
https://github.com/jclouds/jclouds/pull/296.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/296

Reply via email to