> @@ -47,17 +47,17 @@ public DatacenterToLocation(JustProvider provider) {
>     
>      @Override
>      public Location apply(Datacenter datacenter) {
> -        return new LocationBuilder().scope(LocationScope.ZONE)
> -                                    .metadata(ImmutableMap.<String, 
> Object>of())
> +        return new LocationBuilder().id(datacenter.getName())

Changing the `id` is a backward compatibility breaker. People using the 
ComputeService and the `TempalteBuilder.locationId()` will get errors as the 
location might no longer exist.

As this PR is opened against 1.7.x, could the previous ID be kept, and perhaps 
change it in master, if it is a must?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/296/files#r10275498

Reply via email to